feat:add request check callback #384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user can set callback,check request and early response.
|
Code Coverage Report |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #384 +/- ##
==========================================
+ Coverage 62.86% 63.28% +0.42%
==========================================
Files 208 208
Lines 12407 12446 +39
==========================================
+ Hits 7800 7877 +77
+ Misses 4607 4569 -38
☔ View full report in Codecov by Sentry. |
|
加一下测试。 |
Add test done. At the same time find a error in coro client, when request body is bigger than limitation server will return 413 code， but client get code is 404，client don't get correct http status code. |
|
Code Coverage Report |
|
Code Coverage Report |
helintongh
force-pushed
the
feat_control_upload
branch
from
d5b4be7
to
b7a5bf1
Compare
|
Code Coverage Report |
qicosmos
reviewed
Aug 11, 2023
| @@ -403,6 +416,8 @@ inline std::string_view to_string(status_type status) { | |||
| return not_found; | |||
| case status_type::conflict: | |||
| return conflict; | |||
| case status_type::entity_too_large: | |||
There was a problem hiding this comment.
no ut for 413？
coro client get code is 404,don't know why?postman test it that return http code is 413
There was a problem hiding this comment.
It's can be merged. drogon framework has function setClientMaxBodySize to limit client request max body.We can use this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as fowllowing code, can limit client request behavior.
set_body_check 1st parameter is callback, second is response string.